[UIMA-2043] SolrCASConsumers initialize method should be refactored

• Type: Improvement
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Fix Version/s: 2.3.1Addons
• Component/s: Sandbox
• Assignee: Unassigned
• Reporter: Jörn Kottmann
• Created: 09/Feb/11 16:38
• Updated: 06/Apr/11 10:18
• Resolved: 06/Apr/11 10:18

Description

In the initialize method the following is done:

String solrInstanceTypeParam = String.valueOf(context.getConfigParameterValue("solrInstanceType"));
assert solrInstanceTypeParam != null;

The assert will always be true since String.valueOf never returns a null reference, even when
you pass a null reference to it, it will return the string "null".

getConfigParameterValue can actually return null, and we should fail the initialization if
not all necessary parameters to run it are specified in the descriptor. It should fail
with a meaningful error message.
Using assert is not a safe way to fail the initialization because asserts are usually
disabled.