Uploaded image for project: 'Apache Twill'
  1. Apache Twill
  2. TWILL-229

Use the logback_template.xml as the default logback configuration

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 0.11.0
    • Fix Version/s: 0.11.0
    • Component/s: None
    • Labels:
      None

      Description

      It is a regression created by TWILL-122. Without using the logback_template.xml as the default, the AM logs extensively.

        Issue Links

          Activity

          Hide
          githubbot ASF GitHub Bot added a comment -

          GitHub user chtyim opened a pull request:

          https://github.com/apache/twill/pull/49

          (TWILL-229) Default to use logback_template.xml to configure logger, …

          …unless overridden by user

          You can merge this pull request into a Git repository by running:

          $ git pull https://github.com/chtyim/twill feature/TWILL-229

          Alternatively you can review and apply these changes as the patch at:

          https://github.com/apache/twill/pull/49.patch

          To close this pull request, make a commit to your master/trunk branch
          with (at least) the following in the commit message:

          This closes #49


          commit 8aaa15af3132b35fded7424011c1f2a37ef14648
          Author: Terence Yim <chtyim@apache.org>
          Date: 2017-03-30T21:23:36Z

          (TWILL-229) Default to use logback_template.xml to configure logger, unless overridden by user


          Show
          githubbot ASF GitHub Bot added a comment - GitHub user chtyim opened a pull request: https://github.com/apache/twill/pull/49 ( TWILL-229 ) Default to use logback_template.xml to configure logger, … …unless overridden by user You can merge this pull request into a Git repository by running: $ git pull https://github.com/chtyim/twill feature/ TWILL-229 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/twill/pull/49.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #49 commit 8aaa15af3132b35fded7424011c1f2a37ef14648 Author: Terence Yim <chtyim@apache.org> Date: 2017-03-30T21:23:36Z ( TWILL-229 ) Default to use logback_template.xml to configure logger, unless overridden by user
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user yaojiefeng commented on the issue:

          https://github.com/apache/twill/pull/49

          Changes LGTM, may I ask where do we set the logback if it is overriden by user?

          Show
          githubbot ASF GitHub Bot added a comment - Github user yaojiefeng commented on the issue: https://github.com/apache/twill/pull/49 Changes LGTM, may I ask where do we set the logback if it is overriden by user?
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user chtyim commented on the issue:

          https://github.com/apache/twill/pull/49

          For AM, currently it is not settable. For Runnable containers, user can add as resources / localize a `logback.xml` file and specify it in the classpath.

          Show
          githubbot ASF GitHub Bot added a comment - Github user chtyim commented on the issue: https://github.com/apache/twill/pull/49 For AM, currently it is not settable. For Runnable containers, user can add as resources / localize a `logback.xml` file and specify it in the classpath.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user yaojiefeng commented on the issue:

          https://github.com/apache/twill/pull/49

          I see. LGTM

          Show
          githubbot ASF GitHub Bot added a comment - Github user yaojiefeng commented on the issue: https://github.com/apache/twill/pull/49 I see. LGTM
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user asfgit closed the pull request at:

          https://github.com/apache/twill/pull/49

          Show
          githubbot ASF GitHub Bot added a comment - Github user asfgit closed the pull request at: https://github.com/apache/twill/pull/49

            People

            • Assignee:
              chtyim Terence Yim
              Reporter:
              chtyim Terence Yim
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development