Uploaded image for project: 'Apache Twill'
  1. Apache Twill
  2. TWILL-222

TwillRunnable will always have the ROOT log level INFO if we do not explicitly set the log level in TwillPreparer.

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 0.8.0, 0.9.0, 0.10.0
    • Fix Version/s: 0.11.0
    • Component/s: None
    • Labels:
      None

      Description

      TwillPreparer now blindly assumes the ROOT logger has INFO log level if we do not set it no matter what it actually is in the logback.xml. And after we configure the logback.xml in ServiceMain, the root log level get overrided to INFO.

        Issue Links

          Activity

          Hide
          githubbot ASF GitHub Bot added a comment -

          GitHub user yaojiefeng opened a pull request:

          https://github.com/apache/twill/pull/37

          (Twill-222) fix for default root log level

          JIRA: https://issues.apache.org/jira/browse/TWILL-222

          We should not assume the root log level as INFO in TwillPreparer. Removed the INFO level from TwillPreparer to not override what is in the logback.xml.

          You can merge this pull request into a Git repository by running:

          $ git pull https://github.com/yaojiefeng/twill fix/Twill-222-fix-twillPreparer-root-loglevel

          Alternatively you can review and apply these changes as the patch at:

          https://github.com/apache/twill/pull/37.patch

          To close this pull request, make a commit to your master/trunk branch
          with (at least) the following in the commit message:

          This closes #37


          commit 33cf94d661f854b5770ec448531331cf2faafaf7
          Author: yaojiefeng <yaojie@cask.co>
          Date: 2017-03-16T23:57:05Z

          (Twill-222) fix for default root log level


          Show
          githubbot ASF GitHub Bot added a comment - GitHub user yaojiefeng opened a pull request: https://github.com/apache/twill/pull/37 (Twill-222) fix for default root log level JIRA: https://issues.apache.org/jira/browse/TWILL-222 We should not assume the root log level as INFO in TwillPreparer. Removed the INFO level from TwillPreparer to not override what is in the logback.xml. You can merge this pull request into a Git repository by running: $ git pull https://github.com/yaojiefeng/twill fix/Twill-222-fix-twillPreparer-root-loglevel Alternatively you can review and apply these changes as the patch at: https://github.com/apache/twill/pull/37.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #37 commit 33cf94d661f854b5770ec448531331cf2faafaf7 Author: yaojiefeng <yaojie@cask.co> Date: 2017-03-16T23:57:05Z (Twill-222) fix for default root log level
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user asfgit closed the pull request at:

          https://github.com/apache/twill/pull/37

          Show
          githubbot ASF GitHub Bot added a comment - Github user asfgit closed the pull request at: https://github.com/apache/twill/pull/37

            People

            • Assignee:
              yaojie Yaojie Feng
              Reporter:
              yaojie Yaojie Feng
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development