Uploaded image for project: 'Apache Twill'
  1. Apache Twill
  2. TWILL-207

Better have the cache name purely based on class hash to encourage greater reuse.

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.11.0
    • Component/s: None
    • Labels:
      None

      Issue Links

        Activity

        Hide
        githubbot ASF GitHub Bot added a comment -

        GitHub user chtyim opened a pull request:

        https://github.com/apache/twill/pull/35

        (TWILL-207) Only use list of class names as the cache name

        • Also some indentation changes.

        You can merge this pull request into a Git repository by running:

        $ git pull https://github.com/chtyim/twill feature/twill-207

        Alternatively you can review and apply these changes as the patch at:

        https://github.com/apache/twill/pull/35.patch

        To close this pull request, make a commit to your master/trunk branch
        with (at least) the following in the commit message:

        This closes #35


        commit 542850875e0aecbe34d16bca962186b3d32bfb19
        Author: Terence Yim <chtyim@apache.org>
        Date: 2017-03-01T02:03:45Z

        (TWILL-207) Only use list of class names as the cache name

        • Also some indentation changes.

        Show
        githubbot ASF GitHub Bot added a comment - GitHub user chtyim opened a pull request: https://github.com/apache/twill/pull/35 ( TWILL-207 ) Only use list of class names as the cache name Also some indentation changes. You can merge this pull request into a Git repository by running: $ git pull https://github.com/chtyim/twill feature/twill-207 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/twill/pull/35.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #35 commit 542850875e0aecbe34d16bca962186b3d32bfb19 Author: Terence Yim <chtyim@apache.org> Date: 2017-03-01T02:03:45Z ( TWILL-207 ) Only use list of class names as the cache name Also some indentation changes.
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user anwar6953 commented on the issue:

        https://github.com/apache/twill/pull/35

        LGTM

        Show
        githubbot ASF GitHub Bot added a comment - Github user anwar6953 commented on the issue: https://github.com/apache/twill/pull/35 LGTM
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user chtyim commented on the issue:

        https://github.com/apache/twill/pull/35

        Force push a change to trigger travis build again.

        Show
        githubbot ASF GitHub Bot added a comment - Github user chtyim commented on the issue: https://github.com/apache/twill/pull/35 Force push a change to trigger travis build again.
        Hide
        hsaputra Henry Saputra added a comment -

        Could you add bit more description why this changes needed ? Would help with reviews and audit later on.

        Show
        hsaputra Henry Saputra added a comment - Could you add bit more description why this changes needed ? Would help with reviews and audit later on.
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user hsaputra commented on the issue:

        https://github.com/apache/twill/pull/35

        This PR contains both style and functional change, could you help tell a bit where the important changes happen?

        Show
        githubbot ASF GitHub Bot added a comment - Github user hsaputra commented on the issue: https://github.com/apache/twill/pull/35 This PR contains both style and functional change, could you help tell a bit where the important changes happen?
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user chtyim commented on the issue:

        https://github.com/apache/twill/pull/35

        As said in the description, you will see the important changes when ignoring white space changes

        Show
        githubbot ASF GitHub Bot added a comment - Github user chtyim commented on the issue: https://github.com/apache/twill/pull/35 As said in the description, you will see the important changes when ignoring white space changes
        Hide
        chtyim Terence Yim added a comment -

        @hsaput , as the title suggested, it encourage reuse of cached files. I added a link to the related jira that had the file caching logic added.

        Show
        chtyim Terence Yim added a comment - @hsaput , as the title suggested, it encourage reuse of cached files. I added a link to the related jira that had the file caching logic added.
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user hsaputra commented on the issue:

        https://github.com/apache/twill/pull/35

        Ah, yes, sorry, I thought I added the ignore white spaces when load the files changes view.

        Show
        githubbot ASF GitHub Bot added a comment - Github user hsaputra commented on the issue: https://github.com/apache/twill/pull/35 Ah, yes, sorry, I thought I added the ignore white spaces when load the files changes view.
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user hsaputra commented on the issue:

        https://github.com/apache/twill/pull/35

        +1

        Show
        githubbot ASF GitHub Bot added a comment - Github user hsaputra commented on the issue: https://github.com/apache/twill/pull/35 +1
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user asfgit closed the pull request at:

        https://github.com/apache/twill/pull/35

        Show
        githubbot ASF GitHub Bot added a comment - Github user asfgit closed the pull request at: https://github.com/apache/twill/pull/35

          People

          • Assignee:
            chtyim Terence Yim
            Reporter:
            chtyim Terence Yim
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development