Uploaded image for project: 'Apache Twill'
  1. Apache Twill
  2. TWILL-180

TwillController.onTerminated() should pass the exit status of the app to the callback

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 0.7.0-incubating
    • Fix Version/s: 0.11.0
    • Component/s: api, yarn
    • Labels:
      None

      Description

      Listening to this callback, a client can only find out whether an app has terminated, but now how. That makes it hard to distinguish error scenarios: Was the app killed by the user? Did it fail? Or did it successfully complete? There should be an easy way for the client to find out.

        Issue Links

          Activity

          Hide
          chtyim Terence Yim added a comment -

          Supposedly the failure can be get via the Future returned by the teraminte() call. However, currently the YarnTwillController implementation doesn't really reflect the failure state in the future.

          Show
          chtyim Terence Yim added a comment - Supposedly the failure can be get via the Future returned by the teraminte() call. However, currently the YarnTwillController implementation doesn't really reflect the failure state in the future.
          Hide
          githubbot ASF GitHub Bot added a comment -

          GitHub user chtyim opened a pull request:

          https://github.com/apache/twill/pull/54

          (TWILL-180) Reflects YARN application completion status via TwillController

          You can merge this pull request into a Git repository by running:

          $ git pull https://github.com/chtyim/twill feature/TWILL-180

          Alternatively you can review and apply these changes as the patch at:

          https://github.com/apache/twill/pull/54.patch

          To close this pull request, make a commit to your master/trunk branch
          with (at least) the following in the commit message:

          This closes #54


          commit 0e6fd06e4659049dfc335ded9b12a87654de2bda
          Author: Terence Yim <chtyim@apache.org>
          Date: 2017-04-04T06:38:58Z

          (TWILL-180) Reflects YARN application completion status via TwillController


          Show
          githubbot ASF GitHub Bot added a comment - GitHub user chtyim opened a pull request: https://github.com/apache/twill/pull/54 ( TWILL-180 ) Reflects YARN application completion status via TwillController You can merge this pull request into a Git repository by running: $ git pull https://github.com/chtyim/twill feature/ TWILL-180 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/twill/pull/54.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #54 commit 0e6fd06e4659049dfc335ded9b12a87654de2bda Author: Terence Yim <chtyim@apache.org> Date: 2017-04-04T06:38:58Z ( TWILL-180 ) Reflects YARN application completion status via TwillController
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user anwar6953 commented on the issue:

          https://github.com/apache/twill/pull/54

          LGTM

          Show
          githubbot ASF GitHub Bot added a comment - Github user anwar6953 commented on the issue: https://github.com/apache/twill/pull/54 LGTM
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user asfgit closed the pull request at:

          https://github.com/apache/twill/pull/54

          Show
          githubbot ASF GitHub Bot added a comment - Github user asfgit closed the pull request at: https://github.com/apache/twill/pull/54

            People

            • Assignee:
              chtyim Terence Yim
              Reporter:
              anew Andreas Neumann
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development