[TUSCANY-3348] PERF: handleCallback is not optimized

• Type: Improvement
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Fix Version/s: Java-SCA-1.6, Java-SCA-2.x
• Component/s: SCA Java Runtime
• Environment: All
• Assignee: Zhaohui Feng
• Reporter: Hasan Muhammad
• Created: 22/Oct/09 17:23
• Updated: 22/Jun/11 12:09
• Resolved: 28/Oct/09 18:11

Description

The following change in JDKInvocationHandler.handleCallback() improves performance when callback is not defined.

From:
-----------------------------------
private void handleCallback(Message msg, RuntimeWire wire, Object currentConversationID)
throws TargetResolutionException {
ReferenceParameters parameters = msg.getFrom().getReferenceParameters();
parameters.setCallbackID(getCallbackID());
if (msg.getFrom() == null || msg.getFrom().getCallbackEndpoint() == null)

{ return; }

parameters.setCallbackReference(msg.getFrom().getCallbackEndpoint());
------------------------------------


To:
------------------------------------
private void handleCallback(Message msg, RuntimeWire wire, Object currentConversationID)
throws TargetResolutionException {
if (msg.getFrom() == null || msg.getFrom().getCallbackEndpoint() == null) { return; }

ReferenceParameters parameters = msg.getFrom().getReferenceParameters();
parameters.setCallbackID(getCallbackID());

parameters.setCallbackReference(msg.getFrom().getCallbackEndpoint());
-------------------------------------