[TUSCANY-3253] samples/implementation-composite and itest/recursive don't verify successful completion

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: Java-SCA-1.5.1
• Fix Version/s: Java-SCA-1.x
• Component/s: Java SCA Integration Tests, Java SCA Samples
• Assignee: Simon Nash
• Reporter: Simon Nash
• Created: 02/Sep/09 21:01
• Updated: 22/Sep/10 14:47
• Resolved: 22/Sep/10 14:05

Description

The implementation-composite sample and itest/recursive test case don't verify that the callbacks were received. If the callbacks are not received because of null pointer exceptions, the tests appear to pass even though they have failed.

The following output from samples/implementation-composite illustrates this.

Running composite.CompositeTestCase
02-Sep-2009 19:51:54 org.apache.tuscany.sca.node.impl.NodeImpl <init>
INFO: Creating node: null
02-Sep-2009 19:51:56 org.apache.tuscany.sca.node.impl.NodeImpl configureNode
INFO: Loading contribution: file:/F:/tuscany90/sca-java-1.5.1/samples/implementa
tion-composite/target/classes/
02-Sep-2009 19:51:58 org.apache.tuscany.sca.contribution.processor.ValidatingXML
StreamReader
SEVERE: XMLSchema validation error occured in: null ,line = 21, column = 1, Mess
age = cvc-complex-type.3.2.2: Attribute 'targetNamespace' is not allowed to appe
ar in element 'contribution'.
02-Sep-2009 19:52:00 org.apache.tuscany.sca.assembly.builder.impl.CompositePromo
tionBuilderImpl
WARNING: Interface of composite reference InnerSourceComponent/targetReference m
ust be compatible with the interface declared by promoted component reference.
02-Sep-2009 19:52:00 org.apache.tuscany.sca.assembly.builder.impl.CompositePromo
tionBuilderImpl
WARNING: Interface of composite reference InnerSourceComponent/targetReference2
must be compatible with the interface declared by promoted component reference.
02-Sep-2009 19:52:00 org.apache.tuscany.sca.assembly.builder.impl.CompositePromo
tionBuilderImpl
WARNING: Interface of composite service InnerTargetComponent must be subset of t
he interface declared by promoted component service.
02-Sep-2009 19:52:00 org.apache.tuscany.sca.assembly.builder.impl.ComponentRefer
enceWireBuilderImpl
WARNING: Incompatible interfaces on component reference and target: Composite =

{http://sample}

OuterComposite Reference = targetComponentRef Service = TargetCom
ponent
02-Sep-2009 19:52:00 org.apache.tuscany.sca.node.impl.NodeImpl start
INFO: Starting node: null
Main thread Thread[main,5,main]
Source: Client.main -> Source.clientMethod
java.lang.NullPointerException
at composite.SourceImpl.clientMethod(SourceImpl.java:45)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.
java:39)
at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAcces
sorImpl.java:25)
at java.lang.reflect.Method.invoke(Method.java:597)
at org.apache.tuscany.sca.implementation.java.invocation.JavaImplementat
ionInvoker.invoke(JavaImplementationInvoker.java:156)
at org.apache.tuscany.sca.binding.sca.impl.SCABindingInvoker.invoke(SCAB
indingInvoker.java:61)
at org.apache.tuscany.sca.core.invocation.JDKInvocationHandler.invoke(JD
KInvocationHandler.java:346)
at org.apache.tuscany.sca.core.invocation.JDKInvocationHandler.invoke(JD
KInvocationHandler.java:193)
at $Proxy8.clientMethod(Unknown Source)
at composite.CompositeTestCase.test(CompositeTestCase.java:44)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.
java:39)
at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAcces
sorImpl.java:25)
at java.lang.reflect.Method.invoke(Method.java:597)
at junit.framework.TestCase.runTest(TestCase.java:168)
at junit.framework.TestCase.runBare(TestCase.java:134)
at junit.framework.TestResult$1.protect(TestResult.java:110)
at junit.framework.TestResult.runProtected(TestResult.java:128)
at junit.framework.TestResult.run(TestResult.java:113)
at junit.framework.TestCase.run(TestCase.java:124)
at junit.framework.TestSuite.runTest(TestSuite.java:232)
at junit.framework.TestSuite.run(TestSuite.java:227)
at org.junit.internal.runners.JUnit38ClassRunner.run(JUnit38ClassRunner.
java:79)
at org.apache.maven.surefire.junit4.JUnit4TestSet.execute(JUnit4TestSet.
java:62)
at org.apache.maven.surefire.suite.AbstractDirectoryTestSuite.executeTes
tSet(AbstractDirectoryTestSuite.java:138)
at org.apache.maven.surefire.suite.AbstractDirectoryTestSuite.execute(Ab
stractDirectoryTestSuite.java:125)
at org.apache.maven.surefire.Surefire.run(Surefire.java:132)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.
java:39)
at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAcces
sorImpl.java:25)
at java.lang.reflect.Method.invoke(Method.java:597)
at org.apache.maven.surefire.booter.SurefireBooter.runSuitesInProcess(Su
refireBooter.java:308)
at org.apache.maven.surefire.booter.SurefireBooter.main(SurefireBooter.j
ava:879)
02-Sep-2009 19:52:01 org.apache.tuscany.sca.node.impl.NodeImpl stop
INFO: Stopping node: null
Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 7.394 sec

Results :

Tests run: 1, Failures: 0, Errors: 0, Skipped: 0