[TUSCANY-1322] Static code gen objects not deleting contained children successfully

• Type: Bug
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: Java-SDO-M2
• Fix Version/s: Java-SDO-1.0
• Component/s: Java SDO Implementation
• Environment: n/a
• Assignee: Unassigned
• Reporter: David T. Adcox
• Created: 01/Jun/07 17:45
• Updated: 03/Jun/07 07:08
• Resolved: 03/Jun/07 07:08

Description

The SDO 2.1 specification states the following on page 17:

The delete() method unsets all the DataObject's non-readonly properties. The delete()
method will also remove the DataObject from its containing DataObject if the
containment Property is not read-only. All DataObjects recursively contained by
containment properties will also be deleted.

So, it is expected that the contained DOs will delete their contained DOs, and so on, until all DOs have been released under the DO where the delete() method was called. This behavior seems to be working correctly in the case of dynamic DOs, but statically generated DOs are not functioning properly. The contained DOs are still held by their containing DOs.

This fault seems to be caused by a failure in how containment is being tracked in how the underlying EMF code was initialized. The root cause of the failure is a combination of how EMF manages the EClassImpl.eAllStructuralFeatures and how SDO static object types are initialized. In the EClassImpl object, the eAllStructuralFeatures tracks containment properties via a sub-list. This sub-list is created ONLY one time. eAllStructuralFeatures is created the first time, when it is first requested. For static SDO-based applications, this first time is somewhat random depending on the property types being created. During static SDO init there are two key functions of note; the createMetaData() method and the intializeMetaData() method. The createMetaData() method is called first, and all DO properties have an 'empty' properties object created and attached to the DO type. Then, the initializeMetaData() method is called. This method 'configures' each of the blank property objects. The problem is that the eAllStructuralFeatures containment list is constructed early in the initializeMetaData() method, before all the properties have been initialized. So, not all containment properties are recognized and therefore placed into the eAllStructuralFeatures containment list. This then affects the behavior of the DataObjectUtil.delete(DataObject), such that it doesn't properly pull all the contained DOs.

Attached is a zip file with source code and a test schema. In the zip is the test client and associated static code gen classes.