Uploaded image for project: 'Traffic Server'
  1. Traffic Server
  2. TS-840

Regression checks fail (again) due to faulty assert use

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 3.0.0
    • Fix Version/s: 3.1.0, 3.0.1
    • Component/s: Build
    • Labels:
      None

      Description

      When trying to compile regression checks, they fail again for ATS 3.0. They were fixed in TS-738 some time ago, but are now failing again, this time because of a build failure. Problem is the usage of assert():

      libtool: link: g++ -g -O2 -pipe -Wall -Werror -O3 -feliminate-unused-debug-symbols -fno-strict-aliasing -Wno-invalid-offsetof -o .libs/test_Map test_Map.o  ./.libs/libtsutil.so -L/usr/lib -lpcre -lssl -lcrypto -ltcl8.4 -lresolv -lrt -lnsl -lcap -lz -Wl,-rpath -Wl,/usr/lib/trafficserver
      g++ -DHAVE_CONFIG_H -I.   -D_LARGEFILE64_SOURCE=1 -D_COMPILE64BIT_SOURCE=1 -D_GNU_SOURCE -D_REENTRANT -Dlinux -I/usr/include/tcl8.4  -g -O2 -pipe -Wall -Werror -O3 -feliminate-unused-debug-symbols -fno-strict-aliasing -Wno-invalid-offsetof -c -o test_Vec.o test_Vec.cc
      test_Vec.cc: In function 'int main(int, char**)':
      test_Vec.cc:38: error: '__DONT_USE_BARE_assert_USE_ink_assert__' was not declared in this scope
      

      This is due to following definition in lib/ts/ink_assert.h:

      #undef assert
      #define assert __DONT_USE_BARE_assert_USE_ink_assert__
      

      I attached a patch which is fixing this issue.

        Attachments

          Activity

            People

            • Assignee:
              Unassigned
              Reporter:
              at Arno Toell
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: