Uploaded image for project: 'Traffic Server'
  1. Traffic Server
  2. TS-829

socks stats cleanup - some stats are registered, but not used

    XMLWordPrintableJSON

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Minor
    • Resolution: Invalid
    • Affects Version/s: 3.0.0
    • Fix Version/s: None
    • Component/s: Network
    • Labels:

      Description

      From reviewing TS-818 I noticed that the stats that were being double resisted are not used. Some cleanup work should be done for the socks stats.

      Stats that are registered, but not used in the code:
      [bcall@snowball traffic.git]$ grep -r proxy.process.socks iocore/net/Net.cc
      "proxy.process.socks.connections_successful",
      "proxy.process.socks.connections_unsuccessful",
      "proxy.process.socks.connections_currently_open",

      These stats are used some tests, so maybe they should be added back into the code.
      [bcall@snowball traffic.git]$ grep -rl --binary-files=without-match proxy.process.socks.connections_ *
      iocore/net/Net.cc
      mgmt/api/remote/APITestCliRemote.cc
      test/plugin/test-mgmt/test-mgmt.c

      I did however see these stats being used:
      [bcall@snowball traffic.git]$ grep -r SOCKSPROXY_ *
      proxy/SocksProxy.cc:#define SOCKSPROXY_INC_STAT \
      proxy/SocksProxy.cc: SOCKSPROXY_INC_STAT(socksproxy_http_connections_stat);
      proxy/SocksProxy.cc: SOCKSPROXY_INC_STAT(socksproxy_tunneled_connections_stat);

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                tstroh Tyler Stroh
                Reporter:
                bcall Bryan Call
              • Votes:
                0 Vote for this issue
                Watchers:
                3 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: