Uploaded image for project: 'Traffic Server'
  1. Traffic Server
  2. TS-678

Should we reduce MUTEX_RETRY_DELAY ?

    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Closed
    • Major
    • Resolution: Fixed
    • None
    • 2.1.6
    • None
    • None

    Description

      We have a define

      #define MUTEX_RETRY_DELAY HRTIME_MSECONDS(20)

      which might be overly long? A suggestion was to set it to 11ms. bcall reports this being an issue with the old code base as well.

      Long term (post v3.0) I believe John is considering changing several of these locks in cache (and perhaps other areas) to be small critical sections, and just plain locks (and not try-locks). So it's probably not wortwhile for v3.0 to spend significant time on the existing code (hence the quick and dirty reduction in the delay).

      Attachments

        1. mutex-try.diff
          9 kB
          Leif Hedstrom

        Activity

          People

            zwoop Leif Hedstrom
            zwoop Leif Hedstrom
            Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: