[TS-5104] Wrong retry count for OSDNSLookup if url_expansions enabled

• Type: Bug
• Status: Open
• Priority: Major
• Resolution: Unresolved
• Affects Version/s: 6.2.0
• Fix Version/s: 6.2.1
• Component/s: HTTP
• Assignee: Unassigned
• Reporter: Chao Xu
• Created: 22/Dec/16 15:08
• Updated: 22/Dec/16 15:38

Description

1674        HttpTransact::OSDNSLookup(State *s)
1675	{
1676	  static int max_dns_lookups = 3 + s->http_config_param->num_url_expansions;
1677	  ++s->dns_info.attempts;

The max_dns_lookups include :

• 1 for origin domain, for example: oknet
• 1 for default expansion, for example: www.oknet.com
• n for url_expansions_string list, for example: oknet.org, oknet.net

Thus, max_dns_lookups should be ```2 + s->http_config_param->num_url_expansions```

HttpTransact::HostNameExpansionError_t
6614	HttpTransact::try_to_expand_host_name(State *s)
a165134@andrewhsuInitial commit.
andrewhsu authored on 30 Oct 2009
6615	{
6616	  static int max_dns_lookups = 2 + s->http_config_param->num_url_expansions;
6617	  static int last_expansion  = max_dns_lookups - 2;

In the HttpTransact::try_to_expand_host_name, it is correct.

Issue Links

• links to: GitHub Pull Request #1272