[TS-4873] CID 1196428: Resource leaks (CTOR_DTOR_LEAK) in ClusterCom.cc

• Type: Bug
• Status: Open
• Priority: Major
• Resolution: Unresolved
• Fix Version/s: 7.1.0
• Component/s: Clustering
• Assignee: Unassigned
• Reporter: Leif Hedstrom
• Created: 16/Sep/16 13:39
• Updated: 16/Sep/16 13:40

Description

*** CID 1196428:  Resource leaks  (CTOR_DTOR_LEAK)
/mgmt/cluster/ClusterCom.cc: 390 in ClusterCom::ClusterCom(unsigned long, char *, int, char *, int, char *)()
384       //      ink_filepath_make
385       ink_filepath_merge(cluster_conf, sizeof(cluster_conf), p, cluster_file, INK_FILEPATH_TRUENAME);
386       // XXX: Shouldn't we pass the cluster_conf to the Rollback ???
387       //
388       Debug("ccom", "[ClusterCom::ClusterCom] Using cluster file: %s", cluster_file);
389       Debug("ccom", "[ClusterCom::ClusterCom] Using cluster conf: %s", cluster_conf);
   CID 1196428:  Resource leaks  (CTOR_DTOR_LEAK)
   The constructor allocates field "cluster_file_rb" of "ClusterCom" but the destructor and whatever functions it calls do not free it.
390       cluster_file_rb = new Rollback(cluster_file, false);
391     
392       ats_free(cluster_file);
393     
394       if (ink_sys_name_release(sys_name, sizeof(sys_name), sys_release, sizeof(sys_release)) >= 0) {
395         mgmt_log("[ClusterCom::ClusterCom] Node running on OS: '%s' Release: '%s'\n", sys_name, sys_release);

** CID 1021725:  Uninitialized members  (UNINIT_CTOR)
/mgmt/cluster/ClusterCom.cc: 450 in ClusterCom::ClusterCom(unsigned long, char *, int, char *, int, char *)()