Details

    • Bug
    • Status: Closed
    • Major
    • Resolution: Fixed
    • None
    • 6.2.1, 7.0.0
    • Plugins
    • None

    Description

      Seen in the static analyzer:

      Making all in url_sig
        CC       url_sig.lo
      url_sig.c:564:38: warning: Null pointer argument in call to string length function
        app_qry = getAppQueryString(query, strlen(query));
                                           ^~~~~~~~~~~~~
      1 warning generated.
      

      If there is no query string you can still do goto allow, but it looks like the code assumes missing query string will always goto deny.

      Attachments

        Activity

          jrushford John Rushford added a comment -

          merged the fix

          jrushford John Rushford added a comment - merged the fix
          bcall Bryan Call added a comment -

          This was in master at the time the 7.0.x branch was created.

          bcall Bryan Call added a comment - This was in master at the time the 7.0.x branch was created.
          psudaemon Phil Sorber added a comment -

          jrushford, can you create a back port PR for this if it affects 6.2.x?

          psudaemon Phil Sorber added a comment - jrushford , can you create a back port PR for this if it affects 6.2.x?

          People

            jrushford John Rushford
            jamespeach James Peach
            Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Time Tracking

                Estimated:
                Original Estimate - Not Specified
                Not Specified
                Remaining:
                Remaining Estimate - 0h
                0h
                Logged:
                Time Spent - 2h 20m
                2h 20m