[TS-4784] CID 1022032: Error handling issues (CHECKED_RETURN) /plugins/regex_revalidate/regex_revalidate.c

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 7.0.0
• Component/s: Plugins
• Labels: Coverity
• Assignee: Phil Sorber
• Reporter: Leif Hedstrom
• Created: 25/Aug/16 13:49
• Updated: 07/Nov/16 23:25
• Resolved: 26/Aug/16 21:51

Description

*** CID 1022032:  Error handling issues  (CHECKED_RETURN)
/plugins/regex_revalidate/regex_revalidate.c: 478 in TSPluginInit()
472       while ((c = getopt_long(argc, (char *const *)argv, "c:l:", longopts, NULL)) != -1) {
473         switch (c) {
474         case 'c':
475           pstate->config_file = TSstrdup(optarg);
476           break;
477         case 'l':
   CID 1022032:  Error handling issues  (CHECKED_RETURN)
   Calling "TSTextLogObjectCreate" without checking return value (as is done elsewhere 7 out of 8 times).
478           TSTextLogObjectCreate(optarg, TS_LOG_MODE_ADD_TIMESTAMP, &pstate->log);
479           TSTextLogObjectRollingEnabledSet(pstate->log, 1);
480           TSTextLogObjectRollingIntervalSecSet(pstate->log, LOG_ROLL_INTERVAL);
481           TSTextLogObjectRollingOffsetHrSet(pstate->log, LOG_ROLL_OFFSET);
482           break;
483         default:

Issue Links

• links to: GitHub Pull Request #935