Uploaded image for project: 'Traffic Server'
  1. Traffic Server
  2. TS-4784

CID 1022032: Error handling issues (CHECKED_RETURN) /plugins/regex_revalidate/regex_revalidate.c

    XMLWordPrintableJSON

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 7.0.0
    • Component/s: Plugins
    • Labels:

      Description

      *** CID 1022032:  Error handling issues  (CHECKED_RETURN)
      /plugins/regex_revalidate/regex_revalidate.c: 478 in TSPluginInit()
      472       while ((c = getopt_long(argc, (char *const *)argv, "c:l:", longopts, NULL)) != -1) {
      473         switch (c) {
      474         case 'c':
      475           pstate->config_file = TSstrdup(optarg);
      476           break;
      477         case 'l':
         CID 1022032:  Error handling issues  (CHECKED_RETURN)
         Calling "TSTextLogObjectCreate" without checking return value (as is done elsewhere 7 out of 8 times).
      478           TSTextLogObjectCreate(optarg, TS_LOG_MODE_ADD_TIMESTAMP, &pstate->log);
      479           TSTextLogObjectRollingEnabledSet(pstate->log, 1);
      480           TSTextLogObjectRollingIntervalSecSet(pstate->log, LOG_ROLL_INTERVAL);
      481           TSTextLogObjectRollingOffsetHrSet(pstate->log, LOG_ROLL_OFFSET);
      482           break;
      483         default:
      
      

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                psudaemon Phil Sorber
                Reporter:
                zwoop Leif Hedstrom
              • Votes:
                0 Vote for this issue
                Watchers:
                1 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:

                  Time Tracking

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - 0h
                  0h
                  Logged:
                  Time Spent - 50m
                  50m