Uploaded image for project: 'Traffic Server'
  1. Traffic Server
  2. TS-4731

Change return type for TSHttpTxnIsInternal and TSHttpSsnIsInternal

    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Closed
    • Major
    • Resolution: Fixed
    • None
    • 7.0.0
    • TS API

    Description

      I'd like to propose that we modify these two APIs from:

      tsapi TSReturnCode TSHttpTxnIsInternal(TSHttpTxn txnp);
      tsapi TSReturnCode TSHttpSsnIsInternal(TSHttpSsn snap);
      

      to be

      tsapi int TSHttpTxnIsInternal(TSHttpTxn txnp);
      tsapi int TSHttpSsnIsInternal(TSHttpSsn snap);
      

      This is more inline with our current standards of using "int" as a boolean type. This is for example the prototype in TSVConnIsSsl() as well as in e.g. TSHttpTxnDebugSet(TSHttpTxn txnp, int on).

      This is an incompatible change though.

      Attachments

        Issue Links

          Activity

            People

              zwoop Leif Hedstrom
              zwoop Leif Hedstrom
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Time Tracking

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - 0h
                  0h
                  Logged:
                  Time Spent - 2h
                  2h