[TS-4635] Fix HostDB file descriptor handling

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 7.0.0
• Component/s: HostDB
• Assignee: James Peach
• Reporter: James Peach
• Created: 06/Jul/16 00:43
• Updated: 07/Nov/16 23:25
• Resolved: 08/Jul/16 15:38

Description

Various file descriptor handling bugs syncing HostDB.

1. RefCountCacheSerializer::fd is initialized to 0 rather than -1
2. RefCountCacheSerializer::initialize_storage checks for fd <= 0 rather than -1
3. Any time the RefCountCacheSerializer is deleted it leaks the file descripto.
4. Leaks on error paths in RefCountCacheSerializer::finalize_sync()

There is a fd leak somewhere:

[ET_NET 23444 nmadmin   32u   REG              202,1         12   524318 /n/trafficserver/var/host.db.syncing

Issue Links

• links to: GitHub Pull Request #788