[TS-4606] CID 1357056: Resource leaks in P_RefCountCache.

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 7.0.0
• Component/s: HostDB
• Labels: coverity
• Assignee: Thomas Jackson
• Reporter: Leif Hedstrom
• Created: 28/Jun/16 17:29
• Updated: 07/Nov/16 23:27
• Resolved: 28/Jun/16 18:36

Description

** CID 1357056:  Resource leaks  (RESOURCE_LEAK)
/iocore/hostdb/P_RefCountCache.h: 823 in LoadRefCountCacheFromPath<HostDBInfo>(RefCountCache<T1> &, std::basic_string<char, std::char_traits<char>, std::allocator<char>>, std::basic_string<char, std::char_traits<char>, std::allocator<char>>, T1 *(*)(char *, unsigned int))()


________________________________________________________________________________________________________
*** CID 1357056:  Resource leaks  (RESOURCE_LEAK)
/iocore/hostdb/P_RefCountCache.h: 823 in LoadRefCountCacheFromPath<HostDBInfo>(RefCountCache<T1> &, std::basic_string<char, std::char_traits<char>, std::allocator<char>>, std::basic_string<char, std::char_traits<char>, std::allocator<char>>, T1 *(*)(char *, unsigned int))()
817       if (load_func == NULL) {
818         return -1; // TODO: some specific error code
819       }
820     
821       int fd = open(filepath.c_str(), O_RDONLY);
822       if (fd <= 0) {
   CID 1357056:  Resource leaks  (RESOURCE_LEAK)
   Handle variable "fd" going out of scope leaks the handle.
823         return -1; // specific code for missing?
824       }
825     
826       // read in the header
827       RefCountCacheHeader tmpHeader = RefCountCacheHeader();
828       int read_ret                  = read(fd, (char *)&tmpHeader, sizeof(RefCountCacheHeader));