[TS-4578] Skip HostDB lookup for all address literals

• Type: Improvement
• Status: Open
• Priority: Major
• Resolution: Unresolved
• Fix Version/s: sometime
• Component/s: Core, DNS
• Labels: newbie
• Assignee: David Ben Zakai
• Reporter: James Peach
• Created: 23/Jun/16 16:15
• Updated: 22/Dec/16 17:02

Description

In HttpSM.cc:

    if ((strncmp(t_state.dns_info.lookup_name, "127.0.0.1", 9) == 0 || strncmp(t_state.dns_info.lookup_name, "::1", 3) == 0) &&
        ats_ip_pton(t_state.dns_info.lookup_name, t_state.host_db_info.ip()) == 0) {
      // If it's 127.0.0.1 or ::1 don't bother with hostdb
      DebugSM("dns", "[HttpTransact::HandleRequest] Skipping DNS lookup for %s because it's loopback",
              t_state.dns_info.lookup_name);
      t_state.dns_info.lookup_success = true;
      call_transact_and_set_next_state(NULL);
      break;

There's no reason to restrict address literals to loopback. It seems like we should be able to do this for all address literals.

Issue Links

• is related to: TS-3366 TS shouldn't use HostDB for 127.0.0.1 or ::1
• relates to: TS-4987 Cannot set origin server address if remapped to local host.
• links to: GitHub Pull Request #1079