Uploaded image for project: 'Traffic Server'
  1. Traffic Server
  2. TS-4108

SSL metrics have wrong data type

    XMLWordPrintableJSON

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 6.2.0, 7.0.0
    • Component/s: Metrics
    • Labels:
      None

      Description

      All the SSL metrics registered in SSLUtils.cc are specified as RECD_INT, but they are all actually counters and should be specified as RECD_COUNTER.

      The sync function is sometimes given as RecRawStatSyncSum and sometimes RecRawStatSyncCount. Although these functions are identical, we should choose just one.

      Note that the SSL session cache metrics are a little quirky. They are actually counters, but they use SSL_SET_COUNT_DYN_STAT rather than SSL_INCREMENT_DYN_STAT. AFAICT the right way to do this would be to use SSL_INCREMENT_DYN_STAT but clear the SSL_CTX counters on every pass. The way it is done now seems like it would lead to incorrect values when the session cache is cleared or SSL state is reloaded. Unfortunately I don't see an OpenSSL API to clear the counters, so more research is needed there.

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                jamespeach James Peach
                Reporter:
                jamespeach James Peach
              • Votes:
                0 Vote for this issue
                Watchers:
                5 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: