[TS-4083] CID 1343347: Error handling issues in ts_lua_http.c

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 6.2.0
• Component/s: Lua, Plugins
• Assignee: Shu Kit Francis Chan
• Reporter: Shu Kit Francis Chan
• Created: 16/Dec/15 11:28
• Updated: 19/Jul/16 20:16
• Resolved: 22/Dec/15 22:13

Description

** CID 1343347:  Error handling issues  (CHECKED_RETURN)
/plugins/experimental/ts_lua/ts_lua_http.c: 337 in ts_lua_http_set_cache_url()


________________________________________________________________________________________________________
*** CID 1343347:  Error handling issues  (CHECKED_RETURN)
/plugins/experimental/ts_lua/ts_lua_http.c: 337 in ts_lua_http_set_cache_url()
331
332       GET_HTTP_CONTEXT(http_ctx, L);
333
334       url = luaL_checklstring(L, 1, &url_len);
335
336       if (url && url_len) {
>>>     CID 1343347:  Error handling issues  (CHECKED_RETURN)
>>>     Calling "TSCacheUrlSet" without checking return value (as is done elsewhere 4 out of 5 times).
337         TSCacheUrlSet(http_ctx->txnp, url, url_len);
338       }
339
340       return 0;
341     }
342