Uploaded image for project: 'Traffic Server'
  1. Traffic Server
  2. TS-4042

Add feature to buffer request body before making downstream requests

    XMLWordPrintableJSON

    Details

    • Type: Improvement
    • Status: Open
    • Priority: Major
    • Resolution: Unresolved
    • Affects Version/s: None
    • Fix Version/s: 7.1.0
    • Component/s: Core, CPP API, TS API
    • Labels:
      None

      Description

      We need a way to examine the request body without making a downstream request, this feature has many use cases including:

      • Ability to buffer the body and ensure a full post is received before committing downstream resources.
      • Ability to choose an origin based on request body
      • Ability to do request content filtering such as a WAF might provide before the origin is involved.

      Today you have two options to inspect a request body:
      1) Transformations: the problem with transformations is that you only start receiving the request bytes after a sink has been established, which in this case is the downstream origin.
      2) Create an intercept and use fetch apis to then send the downstream request: while this technically works it turns out to be a ton of code and is in general pretty problematic, we actually tried this approach for a while and had nothing but problems with it.

      We feel it would be ideal if we could intercept the body without breaking the normal ATS state flow. There used to exist code (and it's still in the core just #ifdefed out) to drain the request body. I use that code as the basis for this request buffering code. We added APIs to both the C and C++ APIs so that this request buffering can be enabled from a plugin and the plugin can inspect the body as chunks arrive or when it's complete. We've included an example plugin that will error a transaction if a minimum rate of transfer is not maintained.

      I'm confident that this feature will bring plenty of questions / feedback, so let's get that party started.

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                jacksontj Thomas Jackson
                Reporter:
                briang Brian Geffon
              • Votes:
                0 Vote for this issue
                Watchers:
                9 Start watching this issue

                Dates

                • Created:
                  Updated:

                  Time Tracking

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - 0h
                  0h
                  Logged:
                  Time Spent - 40m
                  40m