[TS-3990] CID 1332248: (NEGATIVE_RETURNS) in lib/ts/ink_queue.cc (freelist)

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 6.1.0
• Component/s: Core
• Labels: A
• Assignee: Leif Hedstrom
• Reporter: Leif Hedstrom
• Created: 30/Oct/15 15:54
• Updated: 04/Feb/16 18:48
• Resolved: 02/Nov/15 05:36

Description

*** CID 1332248:    (NEGATIVE_RETURNS)
/lib/ts/ink_queue.cc: 207 in freelist_new(_InkFreeList *)()
201             alloc_size = INK_ALIGN(f->chunk_size * f->type_size, ats_hugepage_size());
202             newp = ats_alloc_hugepage(alloc_size);
203           }
204     
205           if (newp == NULL) {
206             alloc_size = INK_ALIGN(f->chunk_size * f->type_size, ats_pagesize());
   CID 1332248:    (NEGATIVE_RETURNS)
   "ats_pagesize()" is passed to a parameter that cannot be negative.
207             newp = ats_memalign(ats_pagesize(), alloc_size);
208           }
209     
210           ats_madvise((caddr_t)newp, alloc_size, f->advice);
211           SET_FREELIST_POINTER_VERSION(item, newp, 0);
212     
/lib/ts/ink_queue.cc: 207 in freelist_new(_InkFreeList *)()
201             alloc_size = INK_ALIGN(f->chunk_size * f->type_size, ats_hugepage_size());
202             newp = ats_alloc_hugepage(alloc_size);
203           }
204     
205           if (newp == NULL) {
206             alloc_size = INK_ALIGN(f->chunk_size * f->type_size, ats_pagesize());
   CID 1332248:    (NEGATIVE_RETURNS)
   "ats_pagesize()" is passed to a parameter that cannot be negative.
207             newp = ats_memalign(ats_pagesize(), alloc_size);
208           }
209     
210           ats_madvise((caddr_t)newp, alloc_size, f->advice);
211           SET_FREELIST_POINTER_VERSION(item, newp, 0);
212     

Issue Links

• is related to: TS-3883 ats_madvise() has no effect on Linux (including MADV_DONTDUMP)