Uploaded image for project: 'Traffic Server'
  1. Traffic Server
  2. TS-3901

Leaking connections from HttpSessionManager

Details

    • Bug
    • Status: Closed
    • Major
    • Resolution: Fixed
    • None
    • 6.1.0
    • HTTP

    Description

      Observed in production. Got the following warnings in diags.log

      "Connection leak from http keep-alive system"

      Our connections to origin would increase and the number of connections in CLOSE_WAIT were enormous.

      I think the issue was when the origin URL was http with default port. That URL was remapped to https with default port. The default port stored in HttpServerSession->server_ip was not updated.

      When the connection was closed or timed out of the session pool, it would be looked up with port 443. But the session was stored via the server_ip value with port 80 and would never match.

      Relatively small change in HTTPHdr::_file_target_cache.

      Running the fix in production to verify early results.

      Attachments

        1. ts-3901.diff
          2 kB
          Susan Hinrichs

        Issue Links

          Activity

            shinrich Susan Hinrichs added a comment -

            ts-3901.diff contains the changes that we have been running in production that seem to have eliminated the crash.

            shinrich Susan Hinrichs added a comment - ts-3901.diff contains the changes that we have been running in production that seem to have eliminated the crash.

            Commit a54b47c6af06f0ed7739a61d32381e1fd44fa03c in trafficserver's branch refs/heads/master from shinrich
            [ https://git-wip-us.apache.org/repos/asf?p=trafficserver.git;h=a54b47c ]

            TS-3901: Leaking connections from HttpSessionManager.

            jira-bot ASF subversion and git services added a comment - Commit a54b47c6af06f0ed7739a61d32381e1fd44fa03c in trafficserver's branch refs/heads/master from shinrich [ https://git-wip-us.apache.org/repos/asf?p=trafficserver.git;h=a54b47c ] TS-3901 : Leaking connections from HttpSessionManager.

            People

              shinrich Susan Hinrichs
              shinrich Susan Hinrichs
              Votes:
              0 Vote for this issue
              Watchers:
              6 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: