Uploaded image for project: 'Traffic Server'
  1. Traffic Server
  2. TS-3839

Regression test fails by new overridable setting

    XMLWordPrintableJSON

Details

    • Bug
    • Status: Closed
    • Major
    • Resolution: Fixed
    • None
    • 6.0.0
    • Core
    • None

    Description

      Regression test fails by modifications related to TS-3835 .

      $ sudo /usr/local/bin/traffic_server -R 3
      traffic_server: using root directory '/usr/local'
      REGRESSION_TEST initialization begun
      REGRESSION TEST Hdrs started
      ...
      [SDK_API_ENCODING] TSBase64Decode : [TestCase1] <<PASS>> { ok }
          REGRESSION_RESULT SDK_API_ENCODING:                         PASSED
      REGRESSION TEST SDK_API_OVERRIDABLE_CONFIGS started
      FATAL: InkAPI.cc:8118: failed assert `sdk_sanity_check_null_ptr((void *)name) == TS_SUCCESS`
      traffic_server: Aborted (Signal sent by tkill() 13831 99)traffic_server - STACK TRACE: 
      /usr/local/bin/traffic_server(_Z19crash_logger_invokeiP7siginfoPv+0x99)[0x4a53a9]
      /lib64/libc.so.6(+0x326a0)[0x7f92848cb6a0]
      /lib64/libc.so.6(gsignal+0x35)[0x7f92848cb625]
      /lib64/libc.so.6(abort+0x175)[0x7f92848cce05]
      /usr/local/lib/libtsutil.so.6(+0x28c03)[0x7f9286d60c03]
      /usr/local/lib/libtsutil.so.6(+0x28c9d)[0x7f9286d60c9d]
      /usr/local/lib/libtsutil.so.6(+0x266a5)[0x7f9286d5e6a5]
      /usr/local/bin/traffic_server(TSHttpTxnConfigFind+0xa4)[0x4ba824]
      /usr/local/bin/traffic_server(_Z42RegressionTest_SDK_API_OVERRIDABLE_CONFIGSP14RegressionTestiPi+0x122)[0x4f2342]
      /usr/local/lib/libtsutil.so.6(_ZN14RegressionTest3runEPc+0xb3)[0x7f9286d5a2d3]
      /usr/local/bin/traffic_server(_ZN14RegressionCont9mainEventEiP5Event+0x75)[0x4d7fd5]
      /usr/local/bin/traffic_server(_ZN7EThread13process_eventEP5Eventi+0x125)[0x7417a5]
      /usr/local/bin/traffic_server(_ZN7EThread7executeEv+0x6a3)[0x7422c3]
      /usr/local/bin/traffic_server[0x740c1a]
      /lib64/libpthread.so.0(+0x79d1)[0x7f92846839d1]
      /lib64/libc.so.6(clone+0x6d)[0x7f92849818fd]
      

      It seems to lack added config name in SDK_Overridable_Configs[].

      diff --git a/proxy/InkAPITest.cc b/proxy/InkAPITest.cc
      index 704a759..5fefdb3 100644
      --- a/proxy/InkAPITest.cc
      +++ b/proxy/InkAPITest.cc
      @@ -7207,7 +7207,7 @@ const char *SDK_Overridable_Configs[TS_CONFIG_LAST_ENTRY] = {
         "proxy.config.http.cache.max_open_read_retries", "proxy.config.http.cache.range.write",
         "proxy.config.http.post.check.content_length.enabled", "proxy.config.http.global_user_agent_header",
         "proxy.config.http.auth_server_session_private", "proxy.config.http.slow.log.threshold", "proxy.config.http.cache.generation",
      -  "proxy.config.body_factory.template_base"};
      +  "proxy.config.body_factory.template_base", "proxy.config.http.cache.open_write_fail_action"};
       
       REGRESSION_TEST(SDK_API_OVERRIDABLE_CONFIGS)(RegressionTest *test, int /* atype ATS_UNUSED */, int *pstatus)
       {
      

      this patch fix this problem.

      Attachments

        Activity

          People

            jamespeach James Peach
            g-adachi Gota Adachi
            Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: