[TS-382] socket option "cleanup" (and bug fixes)

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Won't Fix
• Component/s: Network
• Assignee: Unassigned
• Reporter: Leif Hedstrom
• Created: 29/May/10 22:30
• Updated: 15/Aug/16 16:20
• Resolved: 15/Aug/16 16:20

Description

This is a bug moved from Y! Bugzilla, I'm posting the original bug description and a few comments separately. Note that the bug description is fairly limited, but while looking at this code, I noticed a lot of oddities with the "socket option" support (lots of hardcoded stuff, and most of it is not configurable).

Note that the original bug should have been fixed already in Apache TS, but the other comments are still applicable.

From Bugzilla (posted by Leif):

We have two socket option config options in records.config:

proxy.config.net.sock_option_flag_in
proxy.config.net.sock_option_flag_out

With accept thread enabled, at least the _in option isn't honored. There are possibly other cases in UnixNetAccept.cc
that we don't honor these flags either.

Issue Links

• is related to: TS-2994 Make use of SO_REUSEPORT socket option
• is related to: TS-3037 Support Setting Of Priority Code Point (PCP) Per IEEE_802.1Q
• is related to: TS-3119 Add option to support SO_LINGER to origin server
• is related to: TS-3094 Add tcp_quickack as one of the socket configuration options for both in and out
• relates to: TS-320 Do some cleanup on Connection::fast_connect and Connection::bind_connect