[TS-3438] npn list being created with garbage data

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Duplicate
• Affects Version/s: 5.3.0
• Component/s: SSL
• Assignee: Sudheer Vinukonda
• Reporter: Sudheer Vinukonda
• Created: 11/Mar/15 22:47
• Updated: 04/Feb/16 19:02
• Resolved: 28/Apr/15 16:26

Description

We noticed that occasionally upon a restart, the npn list built by ATS has garbage data (additional null bytes), resulting in the client failing to decode the ServerHello correctly. The problem would always go away with a restart and is hard to reproduce.

Here's a trace that shows the good vs bad npn lists in the ServerHello:

bad npn list (with spdy and http enabled):

            Extension: next_protocol_negotiation
                Type: next_protocol_negotiation (0x3374)
                Length: 36
                Next Protocol Negotiation
                    Protocol string length: 8
                    Next Protocol: spdy/3.1
                    Protocol string length: 6
                    Next Protocol: spdy/3
                    Protocol string length: 8
                    Next Protocol: http/1.1
                    Protocol string length: 8
                    Next Protocol: http/1.0
                    Protocol string length: 0
                    Protocol string length: 0

good npn list:

            Extension: next_protocol_negotiation
                Type: next_protocol_negotiation (0x3374)
                Length: 34
                Next Protocol Negotiation
                    Protocol string length: 8
                    Next Protocol: spdy/3.1
                    Protocol string length: 6
                    Next Protocol: spdy/3
                    Protocol string length: 8
                    Next Protocol: http/1.1
                    Protocol string length: 8
                    Next Protocol: http/1.0

Issue Links

• duplicates: TS-3031 Race condition in SSLNextProtocolSet::advertiseProtocols