Details

      Description

      "There were fast path(s) in the SocketXXX code when used with a kernel
      non-native BSD-TCP stack on certain platforms. In the current "cleansed"
      code base this is no longer applicable/supported." - George Paul

      Remove SocketManager::fast_close and change all uses to SocketManager::close.
      Remove obsolete argument from SocketManager::close.

      1. ts-333-patch-trunk.txt
        3 kB
        Alan M. Carroll
      2. ts-333-2-1-0-patch.txt
        8 kB
        Alan M. Carroll

        Activity

        Hide
        Alan M. Carroll added a comment -

        Patch is written and (very lightly) tested. I need to construct a test bed suitable for running the regression tests so I can verify the fix (and others).

        Show
        Alan M. Carroll added a comment - Patch is written and (very lightly) tested. I need to construct a test bed suitable for running the regression tests so I can verify the fix (and others).
        Hide
        Alan M. Carroll added a comment -

        Patch generated using SVN diff against the 2.1.0 codebase.

        Show
        Alan M. Carroll added a comment - Patch generated using SVN diff against the 2.1.0 codebase.
        Hide
        Alan M. Carroll added a comment -

        Patch updated with suggestions from mturk

        • In SocketManager::close
          • Used int instead of SOCKET
          • Checked syscall return against -1 instead of < 0
          • Removed printf, return -EACCES or -EINVAL for bad values of parameter
        • Fixed first two in SocketManager::ink_bind also
        Show
        Alan M. Carroll added a comment - Patch updated with suggestions from mturk In SocketManager::close Used int instead of SOCKET Checked syscall return against -1 instead of < 0 Removed printf, return -EACCES or -EINVAL for bad values of parameter Fixed first two in SocketManager::ink_bind also
        Hide
        Alan M. Carroll added a comment -

        Updated patched to be against trunk.

        Show
        Alan M. Carroll added a comment - Updated patched to be against trunk.
        Hide
        Mladen Turk added a comment -

        Committed to trunk. Thanks.

        Show
        Mladen Turk added a comment - Committed to trunk. Thanks.

          People

          • Assignee:
            Mladen Turk
            Reporter:
            Alan M. Carroll
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development