[TS-3188] Do not set half_close flag for short post on keep_alive client connections

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 5.2.0
• Assignee: Susan Hinrichs
• Reporter: Susan Hinrichs
• Created: 11/Nov/14 16:23
• Updated: 18/Dec/14 05:04
• Resolved: 19/Nov/14 17:39

Description

The original logic would set the half_close flag on the client session if all the post information fit in the receive buffer before we started the post tunnel.

However, if the client connection was to be used for multiple requests, this was incorrect.

This flaw exhibited in my test safelyfiled site by doing a folder create (resulting in a short set of post arguments) followed by a file upload that tried to reuse the same connection. The file upload would fail.

Issue Links

• is part of: TS-3105 Combination of fixes for TS-3084 and TS-3073 causing asserts and segfaults on 5.1 and beyond