[TS-3076] Coverity warning and build error on RHEL6

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 5.2.0
• Component/s: Build
• Assignee: James Peach
• Reporter: Leif Hedstrom
• Created: 14/Sep/14 13:31
• Updated: 18/Dec/14 05:13
• Resolved: 15/Sep/14 03:45

Description

With the strtok_r change, we fail on RHEL6, and Coverity gives the same error as well:

*** CID 1238635:  Uninitialized pointer read  (UNINIT)
/example/protocol/TxnSM.c: 951 in parse_request()
945     }
946     
947     /* Parse the server_name and file name from the request. */
948     int
949     parse_request(char *request, char *server_name, char *file_name)
950     {
   CID 1238635:  Uninitialized pointer read  (UNINIT)
   Declaring variable "saveptr" without initializer.
951       char *saveptr, *temp = strtok_r(request, " ", &saveptr);
952       if (temp != NULL)
953         TSstrlcpy(server_name, temp, MAX_SERVER_NAME_LENGTH + 1);
954       else
955         return 0;