[TS-2254] ink_atomic_increment should return the old value

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 4.1.2
• Component/s: Core
• Assignee: Yu Qing
• Reporter: Yu Qing
• Created: 25/Sep/13 05:59
• Updated: 05/Dec/13 23:51
• Resolved: 12/Oct/13 15:28

Description

lib/ts/ink_atomic.h
197 template<>
198 inline int64_t
199 ink_atomic_increment<int64_t>(pvint64 mem, int64_t value)

{ 200 int64_t curr; 201 ink_mutex_acquire(&__global_death); 202 curr = *mem; 203 *mem = curr + value; 204 ink_mutex_release(&__global_death); 205 return curr + value; //SHOULD return curr! 206 }

this function should return the old value (curr, NOT curr + value). it should return same value as gcc inline function __sync_fetch_and_add.