Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 3.3.0
    • Fix Version/s: 3.3.0
    • Component/s: Cache, Stats
    • Labels:
      None

      Description

      patch talks

        Issue Links

          Activity

          Hide
          Igor Galić added a comment -

          The SHA1 is wrong, this is the correct one: 99cbf8acb97b191631882bfcfaf06d512347fdd4

          Show
          Igor Galić added a comment - The SHA1 is wrong, this is the correct one: 99cbf8acb97b191631882bfcfaf06d512347fdd4
          Hide
          Zhao Yongming added a comment -
          commit bf70a5e0613b278c386608ce6f1902eb5b014d05
          Author: Zhao Yongming <ming.zym@gmail.com>
          Date:   Wed Jun 6 10:36:17 2012 +0800
          
              TS-1289 stats codes mess up when disk fail
          
          diff --git a/iocore/cache/Cache.cc b/iocore/cache/Cache.cc
          index 864918a..7ebb99d 100644
          --- a/iocore/cache/Cache.cc
          +++ b/iocore/cache/Cache.cc
          @@ -1685,13 +1685,13 @@ AIO_Callback_handler::handle_disk_failure(int event, void *data) {
                     if (d->fd == gvol[p]->fd) {
                       total_dir_delete += gvol[p]->buckets * gvol[p]->segments * DIR_DEPTH;
                       used_dir_delete += dir_entries_used(gvol[p]);
          -            total_bytes_delete = gvol[p]->len - vol_dirlen(gvol[p]);
          +            total_bytes_delete += gvol[p]->len - vol_dirlen(gvol[p]);
                     }
                   }
           
                   RecIncrGlobalRawStat(cache_rsb, cache_bytes_total_stat, -total_bytes_delete);
          -        RecIncrGlobalRawStat(cache_rsb, cache_bytes_total_stat, -total_dir_delete);
          -        RecIncrGlobalRawStat(cache_rsb, cache_bytes_total_stat, -cache_direntries_used_stat);
          +        RecIncrGlobalRawStat(cache_rsb, cache_direntries_total_stat, -total_dir_delete);
          +        RecIncrGlobalRawStat(cache_rsb, cache_direntries_used_stat, -used_dir_delete);
           
                   if (theCache) {
                     rebuild_host_table(theCache);
          
          Show
          Zhao Yongming added a comment - commit bf70a5e0613b278c386608ce6f1902eb5b014d05 Author: Zhao Yongming <ming.zym@gmail.com> Date: Wed Jun 6 10:36:17 2012 +0800 TS-1289 stats codes mess up when disk fail diff --git a/iocore/cache/Cache.cc b/iocore/cache/Cache.cc index 864918a..7ebb99d 100644 --- a/iocore/cache/Cache.cc +++ b/iocore/cache/Cache.cc @@ -1685,13 +1685,13 @@ AIO_Callback_handler::handle_disk_failure( int event, void *data) { if (d->fd == gvol[p]->fd) { total_dir_delete += gvol[p]->buckets * gvol[p]->segments * DIR_DEPTH; used_dir_delete += dir_entries_used(gvol[p]); - total_bytes_delete = gvol[p]->len - vol_dirlen(gvol[p]); + total_bytes_delete += gvol[p]->len - vol_dirlen(gvol[p]); } } RecIncrGlobalRawStat(cache_rsb, cache_bytes_total_stat, -total_bytes_delete); - RecIncrGlobalRawStat(cache_rsb, cache_bytes_total_stat, -total_dir_delete); - RecIncrGlobalRawStat(cache_rsb, cache_bytes_total_stat, -cache_direntries_used_stat); + RecIncrGlobalRawStat(cache_rsb, cache_direntries_total_stat, -total_dir_delete); + RecIncrGlobalRawStat(cache_rsb, cache_direntries_used_stat, -used_dir_delete); if (theCache) { rebuild_host_table(theCache);

            People

            • Assignee:
              Zhao Yongming
              Reporter:
              Zhao Yongming
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development