Uploaded image for project: 'Traffic Server'
  1. Traffic Server
  2. TS-1043

PATCH: teach TSFetchUrl to use the content-length to find the after_body event

Details

    • Improvement
    • Status: Closed
    • Major
    • Resolution: Won't Fix
    • None
    • None
    • HTTP
    • None

    Description

      TSFetchUrl() does not fire the after_body event until the TCP connection is closed. The fix is to check the content-length when we receive more bytes and to fire the after_body event when all the byte are received.

      This looks like https://issues.apache.org/jira/browse/TS-817 and possibly https://issues.apache.org/jira/browse/TS-912

      Attachments

        Issue Links

          Activity

            jamespeach James Peach added a comment -

            Sigh. This patch breaks TSFetchRespGet() by making it return only the body bytes rather than the whole response.

            jamespeach James Peach added a comment - Sigh. This patch breaks TSFetchRespGet() by making it return only the body bytes rather than the whole response.
            jamespeach James Peach added a comment -

            TSFetchRespGet() returns different results depending on whether you asked for AFTER_HEADER or AFTER_BODY. This patch has the incompatible side-effect of making it consistently return the result from the AFTER_HEADER case. Sigh.

            We probably should reject this patch.

            jamespeach James Peach added a comment - TSFetchRespGet() returns different results depending on whether you asked for AFTER_HEADER or AFTER_BODY. This patch has the incompatible side-effect of making it consistently return the result from the AFTER_HEADER case. Sigh. We probably should reject this patch.
            jamespeach James Peach added a comment -

            The proposed patch breaks the API as described in the previous comment. Resolving as WontFix.

            jamespeach James Peach added a comment - The proposed patch breaks the API as described in the previous comment. Resolving as WontFix.

            People

              jamespeach James Peach
              jamespeach James Peach
              Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: