Uploaded image for project: 'MyFaces Trinidad'
  1. MyFaces Trinidad
  2. TRINIDAD-565

Making renderer APIs public

    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Closed
    • Minor
    • Resolution: Fixed
    • 1.0.0-incubating-core
    • 1.0.0-incubating-core
    • None
    • None

    Description

      quote from Adam Winer of the dev list:

      The goal is to move APIs out of trinidad-impl and into trinidad-api, but
      a number of the desired APIs pulled in a lot of code that really shouldn't
      be made public. So, a bunch of refactoring was called for, introducing
      some pure abstract base classes with reduced functionality, or sometimes
      just eliminating dependencies altogether.

      My planned next step is to move the following APIs over, with
      proposed package names (all under org.apache.myfaces.trinidad,
      of course)

      • render.RenderingContext
      • render.PartialPageContext
      • render.LocaleContext
      • render.FormData
      • skin.Skin
      • skin.Icon

      Option 2 I can think of is to use context.RenderingContext instead
      of render.RenderingContext (and likewise for all the first four).

      After that, the only classes I'm itching to make public are CoreRenderer
      and RenderUtils, both of which would go into o.a.m.t.render. After
      that, I can think of a bunch of candidates, like some of the output
      utility functions in core.xhtml, maybe RenderKitDecorator, etc.,
      but we can take those on more slowly.

      Attachments

        Activity

          People

            adamwiner Adam Winer
            matzew Matthias Wessendorf
            Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: