Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 1.0.0-incubating-core
    • Fix Version/s: 1.0.0-incubating-core
    • Component/s: None
    • Labels:
      None
    • Environment:
      PDA

      Description

      The navigationPane component creates a series of navigation items representing one level in a navigation hierarchy. These items may either be added as children or a menu model may be bound to the navigationPane component.

      Currently, on a PDA, navigationItem in a "tabs" , "bar" and "button" mode does not display properly. Childern and separators get rendered in a new line and that occupies a lot of real screen estate and at the same time, is confusing to the user.

      I plan to fix this.

        Activity

        Transition Time In Source Status Execution Times Last Executer Last Execution Date
        Open Open Patch Available Patch Available
        1d 47m 2 Piyush Hari 19/Oct/06 00:29
        Patch Available Patch Available Open Open
        15d 14h 33m 2 Adam Winer 26/Oct/06 23:56
        Open Open Resolved Resolved
        27m 1 Adam Winer 27/Oct/06 00:23
        Resolved Resolved Closed Closed
        1188d 8h 21m 1 Matthias Weßendorf 27/Jan/10 08:45
        Matthias Weßendorf made changes -
        Status Resolved [ 5 ] Closed [ 6 ]
        Jeff Turner made changes -
        Fix Version/s 1.0.0-incubating-core [ 12312492 ]
        Affects Version/s 1.0.0-incubating-core [ 12312492 ]
        Jeff Turner made changes -
        Affects Version/s 1.0.0-incubating-core [ 12312336 ]
        Project MyFaces ADF-Faces [ 12310300 ] MyFaces Trinidad [ 12310661 ]
        Key ADFFACES-228 TRINIDAD-449
        Fix Version/s 1.0.0-incubating-core [ 12312336 ]
        Matthias Weßendorf made changes -
        Fix Version/s 1.0.0-incubating-core [ 12312336 ]
        Affects Version/s 1.0.0-incubating-core [ 12312336 ]
        Piyush Hari made changes -
        Comment [ I forgot to attach pdaTableRenderer.java in the patch. Here is the updated patch. ]
        Adam Winer made changes -
        Status Open [ 1 ] Resolved [ 5 ]
        Resolution Fixed [ 1 ]
        Adam Winer made changes -
        Status Patch Available [ 10002 ] Open [ 1 ]
        Piyush Hari made changes -
        Piyush Hari made changes -
        Attachment patch_oct18_05_23PM_navigationPane_pda.patch [ 12343206 ]
        Piyush Hari made changes -
        Status Open [ 1 ] Patch Available [ 10002 ]
        Piyush Hari made changes -
        Attachment patch_oct18_05_23PM_navigationPane_pda.patch [ 12343206 ]
        Hide
        Piyush Hari added a comment -

        I am providing a new patch for this issue as per Adam's suggestion. I have created a renderer subclass inheriting from the existing NavigationPaneRenderer.java and added that as the renderer class for a Navigation pane for PDA in the PDA Render Kit.

        Show
        Piyush Hari added a comment - I am providing a new patch for this issue as per Adam's suggestion. I have created a renderer subclass inheriting from the existing NavigationPaneRenderer.java and added that as the renderer class for a Navigation pane for PDA in the PDA Render Kit.
        Adam Winer made changes -
        Status Patch Available [ 10002 ] Open [ 1 ]
        Hide
        Adam Winer added a comment -

        Comments on the patch:

        • _renderNavigationItem() and _renderNonOverlappingItem() already have RenderingContexts; no need to call getCurrentInstance()
        • Some opening braces ('{') are placed on the same line as the code; this is against Trinidad coding standards.
        • In general, -1 to adding "isPDA()" checks, especially the way it's done in
          _renderNonOverlappingItem(). This would be much better handled
          by creating a subclass of NavigationPaneRenderer in the core.pda package that handles
          this rendering distinction. It'd be OK to add a couple of protected methods to the
          base NavigationPaneRenderer class to enable this.
        Show
        Adam Winer added a comment - Comments on the patch: _renderNavigationItem() and _renderNonOverlappingItem() already have RenderingContexts; no need to call getCurrentInstance() Some opening braces ('{') are placed on the same line as the code; this is against Trinidad coding standards. In general, -1 to adding "isPDA()" checks, especially the way it's done in _renderNonOverlappingItem(). This would be much better handled by creating a subclass of NavigationPaneRenderer in the core.pda package that handles this rendering distinction. It'd be OK to add a couple of protected methods to the base NavigationPaneRenderer class to enable this.
        Piyush Hari made changes -
        Issue Type Bug [ 1 ] Improvement [ 4 ]
        Piyush Hari made changes -
        Summary fic navigationPane on PDAs fix navigationPane on PDAs
        Hide
        Piyush Hari added a comment -

        just a typo...

        Show
        Piyush Hari added a comment - just a typo...
        Piyush Hari made changes -
        Status Open [ 1 ] Patch Available [ 10002 ]
        Piyush Hari made changes -
        Field Original Value New Value
        Attachment patch_oct10_01_31AM_navigationPane_pda.patch [ 12342631 ]
        Hide
        Piyush Hari added a comment -

        I am providing patch that fixes this issue. (patch_oct10_01_31AM_navigationPane_pda.patch). Pocket PC, IE Mobile and Backberry do not support style="display:inline" attribute of a table and so, I have arranged the children in a span and not a table.

        Show
        Piyush Hari added a comment - I am providing patch that fixes this issue. (patch_oct10_01_31AM_navigationPane_pda.patch). Pocket PC, IE Mobile and Backberry do not support style="display:inline" attribute of a table and so, I have arranged the children in a span and not a table.
        Piyush Hari created issue -

          People

          • Assignee:
            Unassigned
            Reporter:
            Piyush Hari
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development