Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 1.0.0-incubating-core
    • Fix Version/s: 1.0.0-incubating-core
    • Component/s: None
    • Labels:
      None
    • Environment:
      PDA

      Description

      The navigationPane component creates a series of navigation items representing one level in a navigation hierarchy. These items may either be added as children or a menu model may be bound to the navigationPane component.

      Currently, on a PDA, navigationItem in a "tabs" , "bar" and "button" mode does not display properly. Childern and separators get rendered in a new line and that occupies a lot of real screen estate and at the same time, is confusing to the user.

      I plan to fix this.

        Activity

        Hide
        Piyush Hari added a comment -

        I am providing patch that fixes this issue. (patch_oct10_01_31AM_navigationPane_pda.patch). Pocket PC, IE Mobile and Backberry do not support style="display:inline" attribute of a table and so, I have arranged the children in a span and not a table.

        Show
        Piyush Hari added a comment - I am providing patch that fixes this issue. (patch_oct10_01_31AM_navigationPane_pda.patch). Pocket PC, IE Mobile and Backberry do not support style="display:inline" attribute of a table and so, I have arranged the children in a span and not a table.
        Hide
        Piyush Hari added a comment -

        just a typo...

        Show
        Piyush Hari added a comment - just a typo...
        Hide
        Adam Winer added a comment -

        Comments on the patch:

        • _renderNavigationItem() and _renderNonOverlappingItem() already have RenderingContexts; no need to call getCurrentInstance()
        • Some opening braces ('{') are placed on the same line as the code; this is against Trinidad coding standards.
        • In general, -1 to adding "isPDA()" checks, especially the way it's done in
          _renderNonOverlappingItem(). This would be much better handled
          by creating a subclass of NavigationPaneRenderer in the core.pda package that handles
          this rendering distinction. It'd be OK to add a couple of protected methods to the
          base NavigationPaneRenderer class to enable this.
        Show
        Adam Winer added a comment - Comments on the patch: _renderNavigationItem() and _renderNonOverlappingItem() already have RenderingContexts; no need to call getCurrentInstance() Some opening braces ('{') are placed on the same line as the code; this is against Trinidad coding standards. In general, -1 to adding "isPDA()" checks, especially the way it's done in _renderNonOverlappingItem(). This would be much better handled by creating a subclass of NavigationPaneRenderer in the core.pda package that handles this rendering distinction. It'd be OK to add a couple of protected methods to the base NavigationPaneRenderer class to enable this.
        Hide
        Piyush Hari added a comment -

        I am providing a new patch for this issue as per Adam's suggestion. I have created a renderer subclass inheriting from the existing NavigationPaneRenderer.java and added that as the renderer class for a Navigation pane for PDA in the PDA Render Kit.

        Show
        Piyush Hari added a comment - I am providing a new patch for this issue as per Adam's suggestion. I have created a renderer subclass inheriting from the existing NavigationPaneRenderer.java and added that as the renderer class for a Navigation pane for PDA in the PDA Render Kit.

          People

          • Assignee:
            Unassigned
            Reporter:
            Piyush Hari
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development