[TRINIDAD-2448] Optimize ChangeManager.createDocumentChange() implementation

• Type: Improvement
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 2.1.0-core
• Fix Version/s: 2.1.1-core
• Assignee: Jeanne Waldman
• Reporter: Prakash Udupa
• Created: 24/Jan/14 01:04
• Updated: 27/Jan/16 01:30
• Resolved: 28/Jan/14 22:26

Description

Currently the implementation of org.apache.myfaces.trinidad.change ChangeManager.createDocumentChange( ComponentChange change) does not account for fact that the supplied ComponentChange implementation can also be implementing DocumentChange. Improvement is to do this check first, type cast the supplied component to DocumentChange and return.

There are several ComponentChange implementations in Trinidad that actually also implement DocumentChange, so this is common usecase.

Currently clients need to do this check outside of this call, which can be moved in here.