[TRINIDAD-2196] MenuUtils creates a large number of ThreadLocals

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 1.2.12-core
• Fix Version/s: 2.0.1-core
• Component/s: Components
• Assignee: Scott O'Bryan
• Reporter: Stevan Malesevic
• Created: 10/Jan/12 14:37
• Updated: 21/Feb/12 19:58
• Resolved: 13/Jan/12 23:38

Description

org.apache.myfaces.trinidad.menu.MenuUtils::loadBundle creates a lot of ThreadLocals object which then have a high CPU ipmact at the end of request when they need to be removed

It is not clear:
1) Why ThreadLocal is needed at the first place here
2) Even if it is needed why create it before checking map for existence of bundle