Uploaded image for project: 'MyFaces Trinidad'
  1. MyFaces Trinidad
  2. TRINIDAD-2152

token cache pinning session attribute map

    XMLWordPrintableJSON

Details

    • Bug
    • Status: Closed
    • Major
    • Resolution: Fixed
    • 2.0.1-core
    • 2.0.1-core
    • Components
    • None

    Description

      Stevan Malesevic found that the token cache is pinning the session map.

      com.sun.faces.context.ExternalContextImpl will create a instance of com.sun.faces.context.SessionMap on every request. SessionMap points to
      Request object. However this is per request so it is not carried over between requests. Now, the reason why we always have request object pined between requests is Trinidad code TokenCache which pins the owner (SessionMap) which would otherwise be gc-ed. From what I can see
      Trinidad code can be changed to always get extContext.getSessionMap() instead pinning it permanently. This will make sure we are not pinning Request object and all its attributes in between requests.

      Attachments

        1. TokenCache-trunk.patch
          3 kB
          Gary VanMatre
        2. TokenCache-trunk.patch
          4 kB
          Gary VanMatre

        Activity

          People

            gabrielle Gabrielle Crawford
            gvanmatre@comcast.net Gary VanMatre
            Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: