Uploaded image for project: 'MyFaces Trinidad'
  1. MyFaces Trinidad
  2. TRINIDAD-2151

Missing new JSF 2 signatures on ServletExternalContext

    XMLWordPrintableJSON

Details

    • Bug
    • Status: Closed
    • Major
    • Resolution: Fixed
    • 2.0.2-core
    • 2.0.1-core
    • Components
    • None
    • n/a

    Description

      The ServeletExternalContext extension of the external context doesn't implement the "encodeRedirectURL" method and ends up calling on the base "JSF RI" implementation in ExternalContext. This code is even more confusing as it reference a private "defaultExternalContext" that has no way to set its value. Odd way to implement an abstract interface class IMO.

      public String encodeRedirectURL(String baseUrl,
      Map<String,List<String>> parameters) {

      if (defaultExternalContext != null)

      { return defaultExternalContext.encodeRedirectURL(baseUrl, parameters); }

      throw new UnsupportedOperationException();

      }

      We need to implement a few more of these newer JSF 2 signatures on the ServeletExternalContext.

      Attachments

        1. ServletEC.patch
          12 kB
          Gary VanMatre

        Activity

          People

            darkarena Scott O'Bryan
            gvanmatre@comcast.net Gary VanMatre
            Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: