Uploaded image for project: 'MyFaces Trinidad'
  1. MyFaces Trinidad
  2. TRINIDAD-2045

UIXCollection should release the reference to the model at the very end of processSaveState

Attach filesAttach ScreenshotVotersWatch issueWatchersCreate sub-taskLinkCloneUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

Details

    • Bug
    • Status: Closed
    • Major
    • Resolution: Fixed
    • 1.2.13-core , 1.2.15-core , 2.0.0-core
    • 1.2.15-core , 2.0.0-core
    • Components
    • None

    Description

      UIXCollection is internally hanging onto the collectionModel from applications. This is problematic since the application data could be released between requests. The colleciton model is held internally using iState.value and iState.model.

      This issue was fixed via issue https://issues.apache.org/jira/browse/TRINIDAD-2024.

      However there is code in UIXCollection processSaveState which nulls out and again restores currency(if any) around the saveState call. Unfortunately the call to restore currency could lead to creation of a bogus CollectionModel in UIXTree component.

      The fix is to move the call to null out the references to iState.value and iState.model at the very end of the processSaveState method.

      Attachments

        Activity

          This comment will be Viewable by All Users Viewable by All Users
          Cancel

          People

            darkarena Scott O'Bryan
            venkata.guddanti Venkata Guddanti
            Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Slack

                Issue deployment