Uploaded image for project: 'MyFaces Trinidad'
  1. MyFaces Trinidad
  2. TRINIDAD-2039

Icons are created if the string for the resource is an empty string in Trinidad 1.2

Attach filesAttach ScreenshotVotersWatch issueWatchersCreate sub-taskLinkCloneUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

Details

    • Bug
    • Status: Resolved
    • Minor
    • Resolution: Fixed
    • 1.2.15-core
    • 1.2.15-core
    • Components
    • None

    Description

      The toResourceUri in CoreRenderer returns null for a "" value in Trinidad 2 but not in Trinidad 1.2. What happens is that icons that may evaluate to blank strings (like EL bound icon attributes) may end up rendering a <img src=""> tag in Trinidad 1.2. This results in an extra call to the server in at least some browsers.

      We should backport the fix from Trinidad 2 to 1.2 to prevent this from happening.

      Issue can be reproduced easily with this code:
      <tr:commandButton id="search" text="Search" icon="" action="search"/>

      Attachments

        Activity

          This comment will be Viewable by All Users Viewable by All Users
          Cancel

          People

            arobinson74 Andrew Robinson
            arobinson74 Andrew Robinson
            Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Slack

                Issue deployment