[TRINIDAD-2015] log css parse errors at their source and skip to avoid IllegalArgumentException in FileSystemStyleCache

• Type: Improvement
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 2.0.0-beta-1
• Component/s: Skinning
• Assignee: Jeanne Waldman
• Reporter: Jeanne Waldman
• Created: 19/Jan/11 22:55
• Updated: 25/Jan/11 17:54
• Resolved: 25/Jan/11 17:54

Description

There was a typo in a css file and we got an IllegalArgumentException
that Selector was null. It would have been more helpful if we got an error
earlier in the code at parse time so we know what css file had the parse
error.

The typo was like there was an extra ',' at the end of the selector list. This created a selector with the name "".

.abc, .cde, .efg,
Do not add the empty selector to the list of selectors. Skip it. This will avoid the IllegalArgumentException in FileSystemStyleCache.

java.lang.IllegalArgumentException: selectorString must be non null and non
empty.
at
org.apache.myfaces.trinidad.style.Selector.createSelector(Selector.java:48)
at
org.apache.myfaces.trinidadinternal.style.cache.FileSystemStyleCache$StylesImp
l.<init>(FileSystemStyleCache.java:1348)
at