Uploaded image for project: 'MyFaces Trinidad'
  1. MyFaces Trinidad
  2. TRINIDAD-2011

RowKeySet Attribute Changes surprisingly change object identity

Attach filesAttach ScreenshotVotersWatch issueWatchersCreate sub-taskLinkCloneUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

Details

    • Bug
    • Status: Resolved
    • Major
    • Resolution: Fixed
    • 1.2.13-core , 1.2.14-core , 2.0.0-alpha, 2.0.0-alpha-2
    • 2.0.0-beta-1
    • Components
    • None

    Description

      Whenever the ChangeManager restores a RowKeySet, it changes the identity of the underlying object. This surprises application developers who may have held onto the original instance in order to mutate it and results in the wrong objects being used by the application in many cases. The solution is to preserve the object identity in all cases by reusing the existing RowKeySet and simply clearing it and then adding the new values.

      Attachments

        Activity

          This comment will be Viewable by All Users Viewable by All Users
          Cancel

          People

            btsulliv Blake Sullivan
            btsulliv Blake Sullivan
            Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Time Tracking

                Estimated:
                Original Estimate - 72h
                72h
                Remaining:
                Remaining Estimate - 72h
                72h
                Logged:
                Time Spent - Not Specified
                Not Specified

                Slack

                  Issue deployment