[TRINIDAD-1989] Defltaer/inflater from StateManagerImpl holds onto memory

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 1.2.12-core
• Fix Version/s: 2.0.0-beta-1
• Component/s: Archetype
• Assignee: Unassigned
• Reporter: Stevan Malesevic
• Created: 28/Dec/10 20:09
• Updated: 19/Jan/11 23:51
• Resolved: 19/Jan/11 23:51

Description

StateManagerImpl correctly uses a instance of Deflater/Infalter from session scope for view state compression to avoid recreating these objects since they have finalizers which hurt jvm. Howevere, when returning inflater/deflater to session scope method reset will just reset position for the internal buffer but will not clean buffer. This has impact on preformance since we can pin large buffers for the duration of the session. To avoid this issue we can declare
private static final byte[] empty = new byte[0];

and call decompressor.setInput(empty); and compressor.setInput(empty);