Uploaded image for project: 'MyFaces Trinidad'
  1. MyFaces Trinidad
  2. TRINIDAD-1852

Maven Javascript Plugin: ends up in a packaging loop

    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Patch Available
    • Minor
    • Resolution: Unresolved
    • 2.0.1-plugins
    • None
    • Plugins
    • None

    Description

      The functionality your plugin provides was exactly what we were looking for.
      Except for a small issue we encountered where the contents of the targetDirectory-directive would be added to the
      source-jar (invoked by the addResource-Method).

      Because we provide a slightly unusual targetDirectory-directive(to automate the inclusion of optimized javascript files), the source packaging process(subprocess of maven-source-plugin)
      eventually ends up in a packaging loop, provoked by the source file
      being opened for writing to and reading from in parallel.

      I've attached a patch solving the problem by omitting the inclusion of the targetDirectory if you set addResource to false.

      This is our current maven configuration (pom.xml)

      <plugin>
      <groupId>org.apache.myfaces.trinidadbuild</groupId>
      <artifactId>maven-javascript-plugin</artifactId>
      <configuration>
      <sourcePath>./javascript</sourcePath>
      <sourceDirectory>src/main/webapp/resources</sourceDirectory>
      <targetPath>./debug/javascript</targetPath>
      <targetDirectory>${project.build.directory}</targetDirectory>
      <optimizeTargetPath>./${project.artifactId}-${project.parent.version}/resources/javascript</optimizeTargetPath>
      </configuration>
      <executions>
      <execution>
      <phase>process-resources</phase>
      <goals>
      <goal>reduce-javascript</goal>
      </goals>
      </execution>
      </executions>
      </plugin>
      <plugin>
      <groupId>org.apache.maven.plugins</groupId>
      <artifactId>maven-war-plugin</artifactId>
      <configuration>
      <warSourceExclude>javascript/.js</warSourceExclude>
      </configuration>
      </plugin>

      If you need additional information, let me know.

      Attachments

        1. ReduceJavascriptMojo.patch
          0.7 kB
          Michael Velimirov

        Activity

          People

            matzew Matthias Wessendorf
            mve Michael Velimirov
            Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

              Created:
              Updated: