[TRINIDAD-1588] NullPointerException using labelAndAccessKey Attribute in XMLMenuModel itemNode Definition

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 1.2.12-core
• Fix Version/s: 1.2.13-core
• Component/s: Components
• Assignee: Matthias Wessendorf
• Reporter: Markus Dreher
• Created: 08/Oct/09 07:30
• Updated: 27/Jan/10 08:46
• Resolved: 16/Jan/10 16:43

Description

With Trinidad 1.2.12 i've got the an Exception using the following definition, which worked very well in Version before 1.2.12:

<itemNode id=" administration" immediate="true"
labelAndAccessKey="Administration" rendered="true" disabled="true">
</itemNode>

The labelAndAccessKey Value uses no AccessKey Notation (&), which results in the following NullpointerException:
java.lang.NullPointerException
at org.apache.myfaces.trinidadinternal.menu.ImmutableItemNode._joinLabelAndAccessKey(ImmutableItemNode.java:569)
at org.apache.myfaces.trinidadinternal.menu.ImmutableItemNode.getLabelAndAccessKey(ImmutableItemNode.java:522)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
at java.lang.reflect.Method.invoke(Method.java:585)
at javax.el.BeanELResolver.getValue(BeanELResolver.java:62)
at javax.el.CompositeELResolver.getValue(CompositeELResolver.java:53)
at com.sun.faces.el.FacesCompositeELResolver.getValue(FacesCompositeELResolver.java:72)
at org.apache.el.parser.AstValue.getValue(AstValue.java:97)
at org.apache.el.ValueExpressionImpl.getValue(ValueExpressionImpl.java:186)
at com.sun.facelets.el.TagValueExpression.getValue(TagValueExpression.java:71)

There should be a check for a null accessKey like in ImmutableGroupNode and MenuNode since this is a legal condition.
add before line 522:
if(accessKey == null)

{ return label; }