Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 1.2.11-core
    • Fix Version/s: 1.2.11-core
    • Component/s: Portlet
    • Labels:
      None

      Description

      The method ExternalContextUtils.isAction(final ExternalContext externalContext) does not reliably detect an action request.
      If the object returned by ExternalContext.getRequest() implements the ServletRequest interface the method above returns
      true. This can also apply for a RenderRequest which is not an ActionRequest.

      The following fixes this:

      /**

      • Returns <code>true</code> if this externalContext represents an "action". An action request
      • is any ServletRequest or a portlet ActionRequest. It is assumed that the ExternalContext
        *
      • @return a boolean of <code>true</code> if this is a Portlet ActionRequest or an non-portlet
      • request.
        */
        public static boolean isAction(final ExternalContext externalContext)
        {
        final Object request = externalContext.getRequest();

      if (_PORTLET_ACTION_REQUEST_CLASS == null)

      { _LOG .fine("Portlet API's are not on the classpath so isAction will only check for servlet request."); return request instanceof ServletRequest; }

      return (request instanceof ServletRequest && !_PORTLET_RENDER_REQUEST_CLASS.isInstance(request) ||
      _PORTLET_ACTION_REQUEST_CLASS.isInstance(request)) ;
      }

      _PORTLET_RENDER_REQUEST_CLASS has to be properly initialized. Not sure why this method checks for ServletRequest.

        Attachments

        1. TRINIDAD-1377-patch.txt
          4 kB
          Felix Röthenbacher

          Issue Links

            Activity

              People

              • Assignee:
                darkarena Scott O'Bryan
                Reporter:
                froethenbacher@apache.org Felix Röthenbacher
              • Votes:
                0 Vote for this issue
                Watchers:
                0 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: