[TRINIDAD-1109] Support non-standard user agents

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 1.0.8-core, 1.2.8-core
• Fix Version/s: 1.0.11-core, 1.2.12-core
• Component/s: Skinning
• Environment: User agent string: Mozilla/5.0 (compatible; Konqueror/3.5; Linux) KHTML/3.5.9 (like Gecko)
• Assignee: Andrew Robinson
• Reporter: Alexey Stukalov
• Created: 02/Jun/08 09:37
• Updated: 27/Jan/10 08:45
• Resolved: 17/Feb/09 17:22

Description

Trinidad should be able to render the request for non-supported user agents.
Since 1.x.9 version, user agent's version is mandatory.
If user agent is not recognized and its version is not set, exceptions are thrown:
1) on initial request - "version must be non-null" NPE in org.apache.myfaces.trinidad.context.Version._checkNonEmptyString(Version.java:197)
2) on subsequent requests - NPE in org.apache.myfaces.trinidadinternal.style.cache.FileSystemStyleCache$Key.hashCode(FileSystemStyleCache.java:1131)

The proposed policy is to provide "default" rendering for those agent's that are not recognized/partially recognized (agent type or platform identified, but not version etc).

Issue Links

• relates to: TRINIDAD-1059 Exception when accessing trinidad-demo from Konqueror
• relates to: TRINIDAD-1146 NPE from Google Bot (unknown agent)