[TRINIDAD-1101] Invalid assert and comment in CoreRenderingContext

• Type: Bug
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 1.0.8-core, 1.2.8-core
• Fix Version/s: 1.0.9-core, 1.2.9-core
• Assignee: Scott O'Bryan
• Reporter: Scott O'Bryan
• Created: 28/May/08 23:10
• Updated: 27/Jan/10 08:45
• Resolved: 28/May/08 23:29

Description

The CoreRenderingContext.getFormData() contains an invalid assert that often triggers when asserts are turned on. The invalid assert checks to see if formData is null. I did a check for all code referencing getFormData and they all seem to handle a null value being returned, therefore, this assert is invalid because a null formData seems to be part of the normal execution of this method. Furthermore, the comment on CoreRenderingContext.getFormData() says that the method will create a new formData if one is not present. This does not agree with either the usage OR the assert.

Therefore we need to switch this method so that it works with the current usage of the class.