[TORQUE-93] Joins in Criteria used to delete data can delete datasets also in joined table

• Type: Bug
• Status: Closed
• Priority: Critical
• Resolution: Fixed
• Fix Version/s: 3.3-RC3
• Component/s: Runtime
• Assignee: Thomas Fox
• Reporter: Thomas Fox
• Created: 05/May/07 11:38
• Updated: 05/May/07 11:43
• Resolved: 05/May/07 11:43

Description

Code to reproduce the error:
criteria.add(BookPeer.AUTHOR_ID, authorId);
criteria.addJoin(AuthorPeer.AUTHOR_ID, BookPeer.AUTHOR_ID);
// the following is not needed from a SQL point of view but to generate the unexpected behaviour
criteria.add(AuthorPeer.AUTHOR_ID, authorId);
BookPeer.doDelete(criteria);

Additionally to deleting the chosen books, this will also delete the corresponding authors. What happens is that the criteria gets passed to BasePeer, which tries to figure the table to delete from from the criteria alone. But as it contains two tables in the where clause, it does not know which one is the right table, and deletes the data from both tables.